Tab manager update: Add a bottom toolbar position support #6373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
0nko
changed the title
This was referenced Jul 14, 2025
Base automatically changed from
feature/ondrej/tab-manager-redesign-flag
to
feature/ondrej/tab-manager-redesign
July 18, 2025 09:26
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-bottom-toolbar
branch
from
b41e705 to
3349704
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign
branch
from
d4c5844 to
da3440f
Compare
joshliebe
reviewed
Jul 21, 2025
| this as CoordinatorLayout.LayoutParams | ||
| this.behavior = null | ||
| if (settingsDataStore.omnibarPosition == OmnibarPosition.TOP) { | ||
| this.topMargin = 56.toPx() |
There was a problem hiding this comment.
nit: Should this be a dimen/constant?
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-bottom-toolbar
branch
from
3349704 to
83a0c10
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign
branch
from
da3440f to
f83f061
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign
branch
from
f83f061 to
55988e2
Compare
0nko
force-pushed
the
feature/ondrej/tab-manager-redesign-bottom-toolbar
branch
from
3c1febc to
7479929
Compare
0nko
merged commit 4f0c462
into
feature/ondrej/tab-manager-redesign
6 of 11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/1/137249556945/project/1207418217763355/task/1210728360131190?focus=true
Description
This PR adds the bottom toolbar support, which displays the tab manager toolbar in a position set in the Appearance settings.
Steps to test this PR